CI: Disable the CI Build on push to master branch #2817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the [recent cost-cutting](apache/nuttx#14376), we are no longer running PR Merge Jobs in the `nuttx` and `nuttx-apps` repos. For this to happen, I am now running a script on my computer that will cancel any PR Merge Jobs that appear: [kill-push-master.sh](https://github.com/lupyuen/nuttx-release/blob/main/kill-push-master.sh) This PR disables PR Merge Jobs permanently, so that we no longer need to run the script. This prevents our CI Charges from over-running, in case the script fails to operate properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Due to the recent cost-cutting, we are no longer running PR Merge Jobs in the
nuttxandnuttx-appsrepos. For this to happen, I am now running a script on my computer that will cancel any PR Merge Jobs that appear: kill-push-master.shThis PR disables PR Merge Jobs permanently, so that we no longer need to run the script. This prevents our CI Charges from over-running, in case the script fails to operate properly.
Impact
Some NuttX Developers may wish to run the PR Merge Jobs in their repos. They will have to re-enable the job in
build.yml:Or they may rename the Default Branch from
mastertoreleases/masterbranch. Which will continue to execute PR Merge Jobs:No Impact when Creating / Updating a PR: They will still undergo the same CI Checks.
No Impact to Release Branch: Merging a PR to the Release Branch will still run the PR Merge Job (exactly like today). This ensures that the Release Branch will be verified through complete CI Checks.
No Impact to Docker Builds: When the Dockerfile is updated, it will trigger the CI Workflow
docker_linux.yml. Which is not affected by this PR, and will continue to run (exactly like today).No Impact to Documentation: When the docs are updated, they are published to NuttX Website via the CI Workflow
main.ymlfrom thenuttx-websiterepo (scheduled daily). Which is not affected by this PR, and will continue to run (exactly like today).Testing
Creating a PR will trigger the CI Checks: (exactly like today)
Merging a PR will no longer execute the "Merge Pull Request" job:
If we create a branch
releases/masterand merge a PR: CI Checks shall still execute: